Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2K reusable ingester push workers by default #7128

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

colega
Copy link
Contributor

@colega colega commented Jan 15, 2024

What this PR does

This promotes -distributor.reusable-ingester-push-workers flag to advanced and sets a default value of 2000. This is the value we've been using on Grafana Cloud for a while and we've seen an improvement of up to 7% of CPU usage on the distributors.

Which issue(s) this PR fixes or relates to

Fixes #6776

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

This promotes -distributor.reusable-ingester-push-workers flag to
advanced and sets a default value of 2000. This is the value we've been
using on Grafana Cloud for a while and we've seen an improvement of up
to 7% of CPU usage on the distributors.
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@colega colega marked this pull request as ready for review January 15, 2024 14:20
@colega colega requested review from a team as code owners January 15, 2024 14:20
Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colega colega merged commit d1a6287 into main Jan 15, 2024
28 checks passed
@colega colega deleted the default-distributor-workers-for-ingester-push-requests branch January 15, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce stack allocations by reusing goroutines when pushing series from the distributors to the ingesters
3 participants