Helm: add ruler specific service account #7132

QuantumEnigmaa · 2024-01-15T16:12:39Z

What this PR does

This PR adds a specific service account for the ruler component so that different permissions/authorizations can be given to the ruler.
This can help when using IRSA for example.

Which issue(s) this PR fixes or relates to

Checklist

Tests updated.
Documentation added.
CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
about-versioning.md updated with experimental features.

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

CLAassistant · 2024-01-15T16:12:45Z

All committers have signed the CLA.

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

QuantumEnigmaa · 2024-01-15T16:19:03Z

If maintainers like the idea, I could propagate this change to all components

dimitarvdimitrov · 2024-01-16T16:22:02Z

the idea makes sense to me. I can't think of a technical reason to have a single service account for all pods. @krajorama WDYT?

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

QuantumEnigmaa · 2024-01-22T08:32:03Z

Hey @dimitarvdimitrov any news on this one ?

dimitarvdimitrov

If maintainers like the idea, I could propagate this change to all components

Is this necessary on all components? Is this necessary in your use case? You mentioned IRSA - can you explain what that is and why a separate SA is necessary?

operations/helm/charts/mimir-distributed/templates/_helpers.tpl

operations/helm/charts/mimir-distributed/templates/ruler/ruler-sa.yaml

operations/helm/charts/mimir-distributed/CHANGELOG.md

operations/helm/charts/mimir-distributed/values.yaml

…-specific-sa

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

QuantumEnigmaa · 2024-01-23T09:51:52Z

Is this necessary on all components?

Not really, at least not from my use case perspective for now. But having the possibility to fine tune each and every component is always better than having a monolithic, unified service account for all.

Is this necessary in your use case? You mentioned IRSA - can you explain what that is and why a separate SA is necessary?

Yes, in my use case this is a must. IRSA is short for Iam Role for Service Account, It is a way to access resources from AWS from an AWS Kubernetes cluster by having service accounts with a specific annotation that grant a IAM Role to the pods using it.

In our case, we use this to have mimir pods accessing S3 buckets. We want to have a separate bucket for the ruler along with a separate IAM Role for accessing it, different from the one used by all other mimir components. And since for this we need a separate serviceaccount with a different annotation, that's why we need this PR to be merged

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

QuantumEnigmaa · 2024-01-23T10:39:48Z

@dimitarvdimitrov I disabled the ruler specific sa by default. I also added some lines in the rolebinding template so that the ruler service account is still linked to the same role as other mimir pods

dimitarvdimitrov

thanks for addressing my previous comments.

I also see that the linter found some trailing spaces in values.yaml (visible in the diff view of the PR and in the failing CI action). Can you fix those too, please?

operations/helm/charts/mimir-distributed/templates/_helpers.tpl

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

QuantumEnigmaa · 2024-01-29T09:06:57Z

@dimitarvdimitrov I updated the PR by taking into account your comments but I did it in a "personal" way, or so-to-say.
I kept the .Values.ruler.serviceAccount.create field but I gave 3 possibilities for the user :

The user do not need a specific sa for the ruler so he doesn't change the default values for the Values.ruler.serviceAccount section.
--> This will lead the ruler pods to use the default sa as all the other components.
The user need a specific sa for the ruler but doesn't care for its name so he set .Values.ruler.serviceAccount.create to true but do not change the default value for .Values.ruler.serviceAccount.name.
--> This will lead the ruler pods to use a dedicated sa named after the default sa for mimir with the -ruler suffix.
The user need a specific sa for the ruler and want it to have a specific name so he set .Values.ruler.serviceAccount.create to true and updates the .Values.ruler.serviceAccount.name with a specific value.
--> This will lead the ruler pods to use a dedicated sa which name will be the one from the .Values.ruler.serviceAccount.name field.

Tell me if that's ok for you. Otherwise I can go with what you proposed, getting rid of the .Values.ruler.serviceAccount.create field and only relying on the .Values.ruler.serviceAccount.name one to either create the dedicated sa or not. :)

…-specific-sa

QuentinBisson · 2024-02-05T23:08:59Z

Hello @dimitarvdimitrov would you have some time to help us push this forward this week?

…-specific-sa

dimitarvdimitrov

Amazing! I think your approach looks great. I only left one minor comment, but otherwise LGTM. After you address that we can merge.

Sorry about the delay, I was away last week and travelling back from FOSDEM yesterday.

dimitarvdimitrov · 2024-02-06T16:49:01Z

operations/helm/charts/mimir-distributed/values.yaml

+  # This service account can be used even if the default one is not set.
+  serviceAccount:
+    create: false
+    name: ""


can you add a doc comment (# --) about the meaning of the empty string?

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

…-specific-sa

QuentinBisson · 2024-02-07T09:36:48Z

@dimitarvdimitrov I am sorry for pushing again as this was blocking us from moving foward with mimir so I would really like to thank you for helping us out here :)

I'm not blaming you at all on the delays btw (I know what it's like to maintain open source) and I hope FOSDEM was great :)

I am a just a bit puzzled as it seems to me like you are the only chart maintainer of such a big chart and I thought there would be other maintainers :)

dimitarvdimitrov

LGTM, thanks

I suspect the chart is not the most exciting piece of code in this repo for other maintainers and other maintainers have move on to other projects within Mimir

dimitarvdimitrov · 2024-02-08T15:44:15Z

FYI this change will be included in next week's development release

* Helm: add ruler specific service account Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * add suggestions from review Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * disable ruler sa by default * add rolebinding to ruler sa Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * remove trailing space Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * update handling of ruler sa name Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * add doc comment for ruler sa name Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> --------- Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

@grafanabot

* feat(helm): Adding KEDA autoscaling support * fix: update changelog * feat(helm): Porting the changes from #6971 into helm chart * feat: Adding better changelog & values documentation outlining the experimental state of the feature, using the same autoscaling rules & behaviours as jsonnet, only supporting newest version of KEDA * fix: Remove duplicate query field, add base url in CHANGELOG.md * helm: align grpc server connection lifetime settings with jsonnet (#7269) * helm: align grpc server connection lifetime settings with jsonnet Co-authored-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * helm: rebuild tests Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> --------- Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> * querymiddleware: Fix race condition in shardActiveSeriesMiddleware (#7290) * querymiddleware: race condition in shardActiveSeriesMiddleware s2.Writer is not goroutine-safe to reuse between concurrent requests. Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * querymiddleware: remove flaky ResponseBodyStreamed test from shardActiveSeriesMiddleware --------- Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * version: add UserAgent() (#7264) Update pkg/util/version/info.go Update pkg/mimirtool/client/client.go Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> Co-authored-by: Andy Asp <90626759+andyasp@users.noreply.github.com> * helm: remove -server.grpc.keepalive.max-connection-idle from common config (#7298) Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * Compactor: export estimated number of compaction jobs based on bucket-index (#7299) * Compute number of compaction jobs from bucket index and export it via cortex_bucket_index_compaction_jobs metric. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add PR number. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Remove unused parameter name. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Make linter happy. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Address review feedback. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Fix tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add KubePersistentVolumeFillingUp runbook (#7297) * Add KubePersistentVolumeFillingUp runbook Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed linter Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Internal: remove unnecessary parameter to NoCompactionMarkFilter (#7301) * Remove unnecessary parameter to NewNoCompactionMarkFilter. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Remove unnecessary parameter to NewNoCompactionMarkFilter. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Name query metrics for easier discovery (#7302) Changes the way query metrics are named to make them easier to search for. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * fix(deps): update module github.com/aws/aws-sdk-go to v1.50.11 (#7288) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update module github.com/klauspost/compress to v1.17.6 (#7291) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update anchore/sbom-action action to v0.15.8 (#7286) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update grafana/agent docker tag to v0.39.2 (#7287) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update grafana/grafana docker tag to v10.3.1 (#7292) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update module github.com/failsafe-go/failsafe-go to v0.4.4 (#7289) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Chore: removed unused parameter from GenerateBlockFromSpec() (#7303) * Chore: removed unused parameter from GenerateBlockFromSpec() Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed unused variables Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update mimir-prometheus (#7293) * Update mimir-prometheus Signed-off-by: Marco Pracucci <marco@pracucci.com> * Do not shard histogram_avg() Signed-off-by: Marco Pracucci <marco@pracucci.com> * Re-vendored Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fix TestBucketStore_Series_ShouldQueryBlockWithOutOfOrderChunks Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fix TestGroupCompactE2E Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed TestMultitenantCompactor_OutOfOrderCompaction Signed-off-by: Marco Pracucci <marco@pracucci.com> * Reworked TestBucketStore_Series_ShouldQueryBlockWithOutOfOrderChunks Signed-off-by: Marco Pracucci <marco@pracucci.com> * Simplify TestBucketStore_Series_ShouldQueryBlockWithOutOfOrderChunks Signed-off-by: Marco Pracucci <marco@pracucci.com> * Use filepath.Join() instead of hardcoding path separator Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> * Release mimir-distributed Helm chart 5.3.0-weekly.276 (#7294) * Update mimir-distributed chart to 5.2.0-weekly.276 * Update version to 5.3.0 Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> --------- Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: grafanabot <grafanabot@grafana.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Open circuit breakers on timeouts and per-instance limit errors only (#7310) * Open circuit breakers on timeouts and per-instance limit errors only Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Update CHANGELOG Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> --------- Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Get rid of iterators.chunkIterator and iterators.chunkMergeIterator (#7313) * Get rid of iterators.chunkIterator and iterators.chunkMergeIterator Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> --------- Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Compactor: Language fixes (#7315) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Do not register compat metrics in mimirtool (#7314) This commit does the same as we did for amtool in prometheus/alertmanager#3713. There is no need to register these metrics, so we use compat.NewMetrics(nil) instead of compat.RegisteredMetrics. * Compactor: Un-export symbols that don't need to be exported (#7317) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Circuit breakers: add client.ErrCircuitBreakerOpen type (#7324) Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Add mimirpb.CIRCUIT_BREAKER_OPEN error cause (#7330) * Add mimirpb.CIRCUIT_BREAKER_OPEN error cause Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> --------- Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * store-gateway: remove cortex_bucket_store_blocks_loaded_by_duration (#7309) * store-gateway: remove cortex_bucket_store_blocks_loaded_by_duration The PR which added this metric 6074, the motivation was to help detect compactors which are falling behind. There is another metric `cortex_bucket_store_series_blocks_queried` added by jhalterman in 7112 which serves better the purpose of detecting uncompacted blocks. The reason is that it has an explicit label for uncompacted blocks, and it also is more sensitive to recent blocks (assuming those are queried much more often than old uncompacted blocks). Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add CHANGELOG.md entry Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update CHANGELOG.md Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com> * Update code comment Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> --------- Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com> * ruler: don't retry on non-retriable error (#7216) * ruler: don't retry on non-retriable error Fix 6609 Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * Update CHANGELOG.md Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> --------- Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update Alertmanager to f69a508 (#7332) * Update Alertmanager to f69a508 This commit updates Alertmanager to f69a508. The compat package metrics are removed, and the tests are updated to check that logs are emitted instead. * Fix lint * Fix lint again * Use strings.Trim instead of subslice * Remove integration test TestAlertmanagerMatchersMetrics * Fix lint * Prevent configurations with WebhookURLFile This commit updates the validation rules to prevent Alertmanager configurations for Discord and Microsoft Teams from using WebhookURLFile. * Add additional checks and tests for HTTPConfig * Fix missing nil check * Check for embedded HTTPConfig is not needed * Helm: add ruler specific service account (#7132) * Helm: add ruler specific service account Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * add suggestions from review Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * disable ruler sa by default * add rolebinding to ruler sa Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * remove trailing space Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * update handling of ruler sa name Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * add doc comment for ruler sa name Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> --------- Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * frontend/transport: log non-2xx replies from downstream as non-successful (#7296) Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * querymiddleware: Pool snappy writer in shard activity series (#7308) * querymiddleware: pool snappy writer in shard activity series Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * test concurrent requests in shard active series --------- Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * Helm: make PSP configurable (#7190) * Helm: make PSP configurable Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * fix changelog Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * fix psp rendering Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> * Update operations/helm/charts/mimir-distributed/CHANGELOG.md --------- Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Helm - Templatable host for gateway ingress/route (#7218) * feat: added host templating for gateway ingress * feat: added host templating for gateway route * fix: missing ctx ref * Revert "fix: missing ctx ref" This reverts commit cf956fb. * fix: missing ctx ref * ci: ran make build-helm-tests * updated CHANGELOG.md * fix: re-ordered changelog * feat: added templating to global ingress * fix: added templating to host rules * docs: values.yaml examples * test: rebuild tests according to examples --------- Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * [Docs] Update migrate-from-single-zone-with-helm.md (#7327) * Update migrate-from-single-zone-with-helm.md Fix typo beaching->breaching. * Update changelog * Always sort labels in distributors (#7326) * Always sort labels in distributors Previously, disabling metric relabelling would also disable label sorting. Fixes #7320 * Update comment about sorting * Update CHANGELOG * Do not check for ingester ring state before creating TSDB, or compacting / shipping blocks (#7322) * Do not check for ingester ring state before creating TSDB, or compacting / shipping blocks Signed-off-by: Marco Pracucci <marco@pracucci.com> * Removed unused param Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> * Compactor: String format compaction plan as comma separated blocks (#7321) * Compactor: Format directories as comma separated string Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Compactor: string format plan as comma separated blocks Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Harmonize log message field names Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Add a lifetime manager for Vault authentication tokens (#7337) * Initial renewal implementation * Add metrics and integration test to test token renewal * remove unneeeded comment * Update CHANGELOG.md * Use promauto * address comments * Use global const for Vault image * Add failure metric * Update metrics * Update CHANGELOG and mark as experimental * include metric names in about-versioning * fix(deps): update github.com/grafana/dskit digest to f245b48 (#7283) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Packaging: remove reload from systemd file as mimir does not take into account SIGHUP (#7345) Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> * Docs: No longer mark OTLP endpoint as experimental (#7348) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Update golang.org/x/exp digest to 2c58cdc (#7352) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update module github.com/aws/aws-sdk-go to v1.50.15 (#7353) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update module github.com/minio/minio-go/v7 to v7.0.67 (#7354) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency puppeteer to v21.11.0 (#7355) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update helm/kind-action action to v1.9.0 (#7357) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update module cloud.google.com/go/storage to v1.37.0 (#7358) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Jsonnet / Helm: improve distributors graceful shutdown (#7361) * Jsonnet / Helm: improve distributors graceful shutdown Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fix Helm distributor termination grace period Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> * Release mimir-distributed Helm chart 5.3.0-weekly.277 (#7362) Co-authored-by: grafanabot <grafanabot@grafana.com> * Distributor: Make `-distributor.enable-otlp-metadata-storage` flag default to true, and deprecate (#7366) * Distributor: Change -distributor.enable-otlp-metadata-storage flag's default to true and deprecate --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Mark -ingester.limit-inflight-requests-using-grpc-method-limiter and -distributor.limit-inflight-requests-using-grpc-method-limiter as stable and enable it by default (#7360) * Mark -ingester.limit-inflight-requests-using-grpc-method-limiter and -distributor.limit-inflight-requests-using-grpc-method-limiter as stable and enable it by default Signed-off-by: Marco Pracucci <marco@pracucci.com> * Improved tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Improved tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed unit tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Mark config as deprecated Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> * Do not consider out-of-order blocks when filtering compactable jobs (#7342) * Do not consider out-of-order blocks when filtering compactable jobs Co-authored-by: Marco Pracucci <marco@pracucci.com> * mimir: Inject span profiler into tracer (#7363) * mimir: inject span profiler into tracer Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * Update changelog Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> --------- Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> * Add experimental partitions ring lifecycler support (#7349) * Add experimental partitions ring lifecycler support Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com> * Use http.Error() Signed-off-by: Marco Pracucci <marco@pracucci.com> * Skip deprecated linter check for code that will be soon replaced Signed-off-by: Marco Pracucci <marco@pracucci.com> * Updated dskit Signed-off-by: Marco Pracucci <marco@pracucci.com> * Add partition id to logs Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added comment Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added TestIngester_ShouldNotCreatePartitionIfThereIsShutdownMarker Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com> * feat(helm): Adding KEDA autoscaling support * chore: rebase branch with main * chore: make build-helm-tests --------- Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> Signed-off-by: Peter Štibraný <pstibrany@gmail.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io> Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> Co-authored-by: Vladimir Varankin <vladimir.varankin@grafana.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Andy Asp <90626759+andyasp@users.noreply.github.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Grot (@grafanabot) <43478413+grafanabot@users.noreply.github.com> Co-authored-by: grafanabot <grafanabot@grafana.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Đurica Yuri Nikolić <durica.nikolic@grafana.com> Co-authored-by: George Robinson <george.robinson@grafana.com> Co-authored-by: Zirko <64951262+QuantumEnigmaa@users.noreply.github.com> Co-authored-by: Itay Kalfon <82172131+Itaykal@users.noreply.github.com> Co-authored-by: Éamon Ryan <eamonryan@users.noreply.github.com> Co-authored-by: Patrick Oyarzun <patrick.oyarzun@grafana.com> Co-authored-by: Fayzal Ghantiwala <114010985+fayzal-g@users.noreply.github.com> Co-authored-by: Wilfried ROSET <wilfriedroset@users.noreply.github.com> Co-authored-by: Jonathan Halterman <jonathan@grafana.com>

Helm: add ruler specific service account

ac43977

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

QuantumEnigmaa requested a review from a team as a code owner January 15, 2024 16:12

merge with main

7823f5f

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

merge with main

1ff829a

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

dimitarvdimitrov reviewed Jan 22, 2024

View reviewed changes

QuantumEnigmaa added 2 commits January 23, 2024 10:08

Merge branch 'main' of github.com:QuantumEnigmaa/mimir into add-ruler…

2d9ebc8

…-specific-sa

add suggestions from review

0a40767

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

QuantumEnigmaa added 2 commits January 23, 2024 11:34

disable ruler sa by default

9cca989

add rolebinding to ruler sa

05ae448

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

QuantumEnigmaa mentioned this pull request Jan 23, 2024

Setup PrometheusRules within Mimir ruler giantswarm/roadmap#3127

Closed

dimitarvdimitrov reviewed Jan 26, 2024

View reviewed changes

QuantumEnigmaa added 3 commits January 29, 2024 09:28

merge with main

abd5693

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

remove trailing space

caf8651

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

update handling of ruler sa name

8b3bddd

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

QuantumEnigmaa added 2 commits January 29, 2024 11:21

Merge branch 'main' of github.com:QuantumEnigmaa/mimir into add-ruler…

220f2b6

…-specific-sa

Merge branch 'main' of github.com:QuantumEnigmaa/mimir into add-ruler…

562f377

…-specific-sa

QuantumEnigmaa requested a review from dimitarvdimitrov February 1, 2024 08:21

Merge branch 'main' of github.com:QuantumEnigmaa/mimir into add-ruler…

fd20ae2

…-specific-sa

dimitarvdimitrov reviewed Feb 6, 2024

View reviewed changes

QuantumEnigmaa added 2 commits February 7, 2024 10:14

add doc comment for ruler sa name

28423db

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>

Merge branch 'main' of github.com:QuantumEnigmaa/mimir into add-ruler…

e9d3c75

…-specific-sa

QuantumEnigmaa requested a review from dimitarvdimitrov February 8, 2024 14:30

dimitarvdimitrov approved these changes Feb 8, 2024

View reviewed changes

dimitarvdimitrov enabled auto-merge (squash) February 8, 2024 15:40

dimitarvdimitrov merged commit acc6e7e into grafana:main Feb 8, 2024
30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Helm: add ruler specific service account #7132

Helm: add ruler specific service account #7132

QuantumEnigmaa commented Jan 15, 2024

CLAassistant commented Jan 15, 2024 •

edited

Loading

QuantumEnigmaa commented Jan 15, 2024

dimitarvdimitrov commented Jan 16, 2024

QuantumEnigmaa commented Jan 22, 2024

dimitarvdimitrov left a comment

QuantumEnigmaa commented Jan 23, 2024

QuantumEnigmaa commented Jan 23, 2024

dimitarvdimitrov left a comment

QuantumEnigmaa commented Jan 29, 2024

QuentinBisson commented Feb 5, 2024

dimitarvdimitrov left a comment

dimitarvdimitrov Feb 6, 2024

QuantumEnigmaa Feb 7, 2024

QuentinBisson commented Feb 7, 2024

dimitarvdimitrov left a comment

dimitarvdimitrov commented Feb 8, 2024

Helm: add ruler specific service account #7132

Helm: add ruler specific service account #7132

Conversation

QuantumEnigmaa commented Jan 15, 2024

What this PR does

Which issue(s) this PR fixes or relates to

Checklist

CLAassistant commented Jan 15, 2024 • edited Loading

QuantumEnigmaa commented Jan 15, 2024

dimitarvdimitrov commented Jan 16, 2024

QuantumEnigmaa commented Jan 22, 2024

dimitarvdimitrov left a comment

Choose a reason for hiding this comment

QuantumEnigmaa commented Jan 23, 2024

QuantumEnigmaa commented Jan 23, 2024

dimitarvdimitrov left a comment

Choose a reason for hiding this comment

QuantumEnigmaa commented Jan 29, 2024

QuentinBisson commented Feb 5, 2024

dimitarvdimitrov left a comment

Choose a reason for hiding this comment

dimitarvdimitrov Feb 6, 2024

Choose a reason for hiding this comment

QuantumEnigmaa Feb 7, 2024

Choose a reason for hiding this comment

QuentinBisson commented Feb 7, 2024

dimitarvdimitrov left a comment

Choose a reason for hiding this comment

dimitarvdimitrov commented Feb 8, 2024

CLAassistant commented Jan 15, 2024 •

edited

Loading