Rename metric to cortex_querier_query_storegateway_chunks_total #7145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename cortex_query_storegateway_chunks_total to cortex_querier_query_storegateway_chunks_total - Add metric to test cases
4 tasks
jhesketh
approved these changes
Jan 17, 2024
pracucci
reviewed
Jan 17, 2024
There was a problem hiding this comment.
I left a couple of comments. To fix the integration tests, please add cortex_querier prefix as a valid prefix for the Ruler in integration/asserts.go (reason is that the ruler internally runs the querier when running without the external rule evaluation, so it's valid if ruler exposes querier's metrics).
jhalterman
force-pushed
the
querier-metrics-follow-on
branch
from
995fa5b
to
d3431cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
cortex_query_storegateway_chunks_totaltocortex_querier_query_storegateway_chunks_totalFollow-up to #7099
Which issue(s) this PR fixes or relates to
Addresses a comment from a previous PR: #7099 (comment)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.