Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest storage: configure BrokerMaxReadBytes on Kafka reader #7148

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

pracucci
Copy link
Collaborator

What this PR does

A tiny PR to set BrokerMaxReadBytes on the Kafka reader (used by the new experimental ingest storage). The Kafka library suggests to set it to 2x FetchMaxWait.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci marked this pull request as ready for review January 17, 2024 09:32
@pracucci pracucci requested a review from a team as a code owner January 17, 2024 09:32
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only left one small suggestion about the comment

Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@pracucci pracucci enabled auto-merge (squash) January 17, 2024 10:45
@pracucci pracucci merged commit 5c37e4e into main Jan 17, 2024
28 checks passed
@pracucci pracucci deleted the configure-BrokerMaxReadBytes branch January 17, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants