-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documented ingeter migration to spread-minimizing tokens #7174
Conversation
f2600ff
to
d691044
Compare
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
d691044
to
2ba208c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from technical point of view, this matches my understanding and the doc I've reviewed before.
@duricanikolic Thank you for submitting some documentation. I checked out your PR to do a local build. The page isn't showing up in the local build. I'm going to troubleshoot locally and hopefully fix the issue. Update: Issue is fixed. I did my suggested edits while I had the page checked out. I'll leave comments where I made changes. |
docs/sources/mimir/configure/configure-spread-minimizing-tokens/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/mimir/configure/configure-spread-minimizing-tokens/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/mimir/configure/configure-spread-minimizing-tokens/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/mimir/configure/configure-spread-minimizing-tokens/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/mimir/configure/configure-spread-minimizing-tokens/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/mimir/configure/configure-spread-minimizing-tokens/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/mimir/configure/configure-spread-minimizing-tokens/_index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some wording changes and marked what I did in the PR. I also found some additional mistaskes that I introduced. I've left them as suggestions so you can see where I made changes.
Please let me know if you have any questions. I'm happy to explain.
docs/sources/mimir/configure/configure-spread-minimizing-tokens/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/mimir/configure/configure-spread-minimizing-tokens/_index.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Thank you very much @knylander-grafana. I have applied your suggestions, and will merge the PR. |
What this PR does
This PR adds a documentation on how to migrate ingesters to
spread-minimizing
tokens.Which issue(s) this PR fixes or relates to
Part of #4736
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.