Chore: remove superfluous errors.Cause() usage in pkg/storage #7212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In this PR I'm removing superfluous
errors.Cause()
usage inpkg/storage
. This usage oferrors.Is(errors.Cause(), ...)
was introduced in #3288 when removing Thanos dependency.The reason why
errors.Cause()
is superfluous is becauseerrors.Is()
already navigates the chain of wrapped errors, so we don't have to look at theCause()
of an error. I've checked all places where these errors are returned, and they're all correctly wrapped witherrors.Wrap()
(soerrors.Is()
is enough). In addition, for the errors returned byReadMarker()
, in other places in the code we just check the same errors using onlyerrors.Is()
, another signal thaterrors.Cause()
is not needed.Note: this PR is part of a work I'm doing to completely remove
errors.Cause()
from Mimir.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.