Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensible "Rollout progress" workload grouping #7228

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Extensible "Rollout progress" workload grouping #7228

merged 2 commits into from
Jan 26, 2024

Commits on Jan 26, 2024

  1. Extensible "Rollout progress" workload grouping 

    We have some cells where we have multiple deployments (10+) for the same
workload. They make the rollout progress dashboard unreadable.

In this PR I'm extracting the `label_replace(...)` calls from the
"Rollout progress" panel into an array in the config, so users can
extend that with their workload matchers.

I also used this opportunity to:
- Replace `cortex_service` label with `workload`.
- Change query from regexp-matching on the metric name to
  kube_statefulset_... or kube_deployment_...: this is required for
  Adaptive Metrics to correctly process this metric name lookup.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @colega
    colega committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    496bfa2 View commit details
    Browse the repository at this point in the history

  2. make build-helm-tests 

    Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @colega
    colega committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    51227c8 View commit details
    Browse the repository at this point in the history