Use concurrency.ForEachJob() from new dskit #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: grafana/dskit#113 Updated all usages of concurrency.ForEach() to use ForEachJob() so no type assertion is needed anymore. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
commented
Jan 12, 2022
| compID := j.(ulidWithShardIndex).ulid | ||
| blocksToUpload := convertCompactionResultToForEachJobs(compIDs, job.UseSplitting(), jobLogger) | ||
| err = concurrency.ForEachJob(ctx, len(blocksToUpload), c.blockSyncConcurrency, func(ctx context.Context, idx int) error { | ||
| blockToUpload := blocksToUpload[idx] | ||
|
|
||
| uploadedBlocks.Inc() |
There was a problem hiding this comment.
I didn't want to extend the scope of this PR but this isn't needed, we can just use len(blocksToUpload) later.
pracucci
deleted the
use-concurrency-for-each-job-from-new-dskit-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates dskit to include grafana/dskit#113
Updated all usages of
concurrency.ForEach()to useForEachJob()so no type assertion is needed anymore.Which issue(s) this PR fixes:
Follow up on #707
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]