Optimize memory allocation in histogram iterators #7319
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Prometheus introduced a possibility to optionally reuse the memory area of the given histogram or float histogram to reduce allocation (prometheus/prometheus#13340). We highlight the functions from the
chunkenc.Iterator
interface, that are of particular importance for the above mentioned change:In #7274 we adapted Mimir's
chunk.Iterator
interface in such a way that itsAtHistogram()
andAtFloatHistogram()
methods follow the signature of the corresponding methods of Prometheus'chunkenc.Iterator
, i.e., they now also contain optional arguments of type*histogram.Histogram
and*histogram.FloatHistogram
that allow memory allocation optimization. Mimir'schunk.prometheusChunkIterator
, an implementation ofchunk.Iterator
, was also updated accordingly.In this PR we additionally optimize histogram and float histogram memory allocations by modifying
chunk.prometheusChunkIterator
's implementation ofBulk()
.A comparison between the old and the new implementation of
Bulk()
actually showed an improvement in memory allocation:Which issue(s) this PR fixes or relates to
Part of #7235
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.