Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timely head compaction support #7372

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Add timely head compaction support #7372

merged 2 commits into from
Feb 13, 2024

Conversation

jhalterman
Copy link
Member

@jhalterman jhalterman commented Feb 13, 2024 •
edited
Loading

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #7306

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jhalterman jhalterman marked this pull request as ready for review February 13, 2024 16:21
@jhalterman jhalterman requested review from grafanabot and a team as code owners February 13, 2024 16:21
pracucci
pracucci approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Please remember to run make reference-help doc.

pkg/storage/tsdb/config.go Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@jhalterman jhalterman requested a review from a team as a code owner February 13, 2024 17:50
@jhalterman jhalterman merged commit 82f4ad8 into grafana:main Feb 13, 2024
28 checks passed
@jhalterman jhalterman deleted the timely-compaction branch February 13, 2024 18:41
grafanabot pushed a commit that referenced this pull request Feb 13, 2024
@jhalterman @grafanabot
Add timely head compaction support (#7372)
e2805c1 
* Add timely head compaction support

(cherry picked from commit 82f4ad8)
@grafanabot grafanabot mentioned this pull request Feb 13, 2024
Merged
jhalterman added a commit that referenced this pull request Feb 13, 2024
@grafanabot @jhalterman
Add timely head compaction support (#7372) (#7373)
3cc3e70 
* Add timely head compaction support

(cherry picked from commit 82f4ad8)

Co-authored-by: Jonathan Halterman <jonathan@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

Assignees
No one assigned
Labels
backport r277
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Head compaction range check prevents timely compaction
2 participants
@jhalterman @pracucci