Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error in autoscaling jsonnet #7374

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

56quarters
Copy link
Contributor

@56quarters 56quarters commented Feb 13, 2024

What this PR does

Fixes an issue where the CPU parsing method sometimes returns an integer and sometimes returns a string.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Fixes an issue where the CPU parsing method sometimes returns an
integer and sometimes returns a string.

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters marked this pull request as ready for review February 13, 2024 19:56
@56quarters 56quarters requested a review from a team as a code owner February 13, 2024 19:56
Copy link
Contributor

@leizor leizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@56quarters 56quarters merged commit f5a7b5c into main Feb 13, 2024
28 checks passed
@56quarters 56quarters deleted the 56quarters/i-love-jsonnet branch February 13, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants