mimir-mixin: Fix "unexpected type object, expected array" #7457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
narqo
commented
Feb 23, 2024
Comment on lines
+138
to
+153
| if $._config.show_rejected_requests_on_writes_dashboard then | ||
| { | ||
| targets: [ | ||
| { | ||
| legendLink: null, | ||
| expr: 'sum (rate(cortex_distributor_instance_rejected_requests_total{%s}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.distributor)], | ||
| format: 'time_series', | ||
| intervalFactor: 2, | ||
| legendFormat: 'rejected', | ||
| refId: 'B', | ||
| }, | ||
| ] + super.targets, | ||
| } + $.aliasColors({ | ||
| rejected: '#EAB839', | ||
| }) | ||
| else {}, |
There was a problem hiding this comment.
tl;dr; of these changes:
- if C { targets: [···] + {···} }
+ if C { targets: [···] } + {···}
56quarters
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is a fixup for #7413
When
show_rejected_requests_on_writes_dashboardis set in the config, the code path inwrites.libjsonnetfails withThis is due to how I originally misinterpreted the
{}in theif C then {}as condition C's block:TIL (1) the
{}is an actual object, inserted into the resulting JSON.TIL (2)
jsonnet's linter doesn't catch a broken syntax, i.e.[] + {}, when this happens inside a dead code.Note there are no assets to rebuild for the PR, because the mentioned config is unset in mimir. But the problem showed itself in the internal build.
Which issue(s) this PR fixes or relates to
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.