Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mimir-mixin] Add owned series to tenant dashboard #7511

Merged
merged 4 commits into from
Mar 4, 2024
Merged

[mimir-mixin] Add owned series to tenant dashboard #7511

merged 4 commits into from
Mar 4, 2024

Conversation

pr00se
Copy link
Contributor

@pr00se pr00se commented Feb 29, 2024 •
edited
Loading

What this PR does

On the Tenants dashboard:

  • Adds owned series to the "All series" panel
  • Adds in-memory series and owned series per ingester panels
  • Moves "Newest seen sample age" panel to the Distributor row
  • Moves native histogram panels to the exemplars row (and renames the row)

One side-effect is that the owned series in the "All series" panel is drawn over the in-memory series line, but I think that's ok.

Screenshot 2024-02-29 at 7 05 13 PM

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@pr00se pr00se marked this pull request as ready for review February 29, 2024 23:28
@pr00se pr00se requested a review from a team as a code owner February 29, 2024 23:28
krajorama
krajorama approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unsure about the UX, but we'll see

@pr00se pr00se merged commit cba0d35 into main Mar 4, 2024
31 checks passed
@pr00se pr00se deleted the mixin-owned-series branch March 4, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@56quarters 56quarters 56quarters approved these changes

@krajorama krajorama krajorama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pr00se @56quarters @krajorama