-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the release version in CHANGELOG.md and VERSION #7599
Conversation
renovate.json
Outdated
@@ -3,15 +3,15 @@ | |||
"extends": [ | |||
"config:base" | |||
], | |||
"baseBranches": ["main", "release-2.11", "release-2.10"], | |||
"baseBranches": ["main", "release-2.12", "release-2.11"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does renovate look at this file on the branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure. But it is better to keep this one up-to-date too, at least for completeness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree. I find it confusing to make unnecessary changes. If we want to include new branch, we should do it in file that's actually used.
Furthermore if we merge this branch into main
after creating rc-0, we will effectively stop getting updates for release-2.10, even though release-2.12 wasn't released yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renovate always uses the config from the repository's default branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the changes I previously did in renovate.json
, and I will now merge this PR.
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
57e8595
to
7f9823b
Compare
What this PR does
This PR makes the following changes:
CHANGELOG.md
to2.12.0-rc.0
.VERSION
to2.12.0-rc.0
.Which issue(s) this PR fixes or relates to
Part of #7542
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.