querier: don't cache context.Canceled errors for bucket index #7620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a cached bucket index the querier will synchronously fetch the bucket index while the query is on hold. If the query is cancelled, then the error will be cached and future queries would return the error until the next periodic bucket index update (after 1 minute). Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
1 task
pstibrany
approved these changes
Mar 13, 2024
| "cortex_bucket_index_loads_total", | ||
| "cortex_bucket_index_load_failures_total", | ||
| "cortex_bucket_index_loaded", | ||
| )) |
There was a problem hiding this comment.
Shall we request index one more time with non-canceled context to show that it succeeds?
There was a problem hiding this comment.
done in a96308c
jhalterman
approved these changes
Mar 13, 2024
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
…o-on-bucket-index-fetches
dimitarvdimitrov
deleted the
dimitar/querier/dont-caceh-context-cancelatio-on-bucket-index-fetches
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Without a cached bucket index the querier will synchronously fetch the bucket index while the query is on hold. If the query is cancelled, then the error will be cached and future queries would return the error until the next periodic bucket index update (after 1 minute).
Which issue(s) this PR fixes or relates to
Fixes #7586 (comment)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.