Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move -querier.minimize-ingester-requests from experimental to advanced #7638

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

duricanikolic
Copy link
Contributor

@duricanikolic duricanikolic commented Mar 16, 2024

What this PR does

This PR is needed for the release of Mimir 2.12.

Experimental CLI flag -querier.minimize-ingester-requests has been enabled by default and marked for deletion in Mimir 2.12 in #6174.

After a more detailed analysis, we realized that this CLI flag might be still needed. Therefore, this PR sets it as advanced.

Which issue(s) this PR fixes or relates to

Part of #7542

Checklist

  • [na] Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@duricanikolic duricanikolic self-assigned this Mar 16, 2024
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer if we keep this option for now, because I'm not convinced that minimising ingester requests is the right approach for the experimental "ingest storage" architecture we're working on. I suggest to mark this option as advanced instead of experimental and keep it enabled by default for now.

@duricanikolic duricanikolic changed the title Get rid of -querier.minimize-ingester-requests Move -querier.minimize-ingester-requests from experimental to advanced Mar 18, 2024
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
@duricanikolic duricanikolic marked this pull request as ready for review March 18, 2024 10:36
@duricanikolic duricanikolic requested review from jdbaldry and a team as code owners March 18, 2024 10:36
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. As mentioned to Yuri I prefer to keep this flag to have a quick way to disable it as part of the experimental ingest storage we're building.

@duricanikolic duricanikolic merged commit 83dc978 into main Mar 18, 2024
29 checks passed
@duricanikolic duricanikolic deleted the yuri/deprecated-features branch March 18, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants