Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tenants to be included or excluded from store-gateways #7653

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

56quarters
Copy link
Contributor

@56quarters 56quarters commented Mar 18, 2024

What this PR does

Add configuration to the store-gateway to allow specific tenants to be
enabled or disabled using the same logic as the corresponding configuration
in the compactor. Useful for ensuring that a particular tenant generating
a huge number of blocks doesn't consume all disk space on store-gateways
while waiting for compaction to reduce block count.

Which issue(s) this PR fixes or relates to

Fixes #7031

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@56quarters 56quarters force-pushed the 56quarters/sg-allow-users branch 2 times, most recently from 4c21e8f to dd21132 Compare March 19, 2024 18:23
Add configuration to the store-gateway to allow specific tenants to be
enabled or disabled using the same logic as the corresponding configuration
in the compactor. Useful for ensuring that a particular tenant generating
a huge number of blocks doesn't consume all disk space on store-gateways
while waiting for compaction to reduce block count.

Fixes #7031

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters marked this pull request as ready for review March 19, 2024 19:00
@56quarters 56quarters requested review from jdbaldry and a team as code owners March 19, 2024 19:00
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM, I left a minor suggestion.

pkg/storegateway/sharding_strategy.go Outdated Show resolved Hide resolved
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, lgtm.

@56quarters 56quarters merged commit f09e78a into main Mar 20, 2024
29 checks passed
@56quarters 56quarters deleted the 56quarters/sg-allow-users branch March 20, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add enabled/disabled tenants flags to store gateway configuration.
2 participants