Update dskit #7698
Merged
Update dskit #7698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
reviewed
Mar 22, 2024
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
…-pools-enabled from auto-generated config Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Updating dskit to get grafana/dskit#509.
There also new 3 config options to dskit's
Server:-server.proxy-protocol-enabled: adds support to PROXY protocol. I'm not sure it's of any value for Mimir users, but shouldn't hurt, so I've kept it and marked experimental.-server.grpc.recv-buffer-pools-enabled: this is tricky. I don't have bandwidth to verify if it's safe in Mimir, so I propose to keep its config hidden for now and forced tofalse.-server.grpc.stats-tracking-enabled: this was introduced in dskit to allow to set-server.grpc.recv-buffer-pools-enabled=true(a pre-requisite is not using gRPC stats handler because unsafe with recv buffer pools). I've hidden it from the doc too, given I've forced-server.grpc.recv-buffer-pools-enabledtofalseWhich issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.