Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote rule reads dashboard: add ruler-querier in-flight queries scaling metric panel #7749

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

pracucci
Copy link
Collaborator

What this PR does

In Grafana Cloud I'm rolling out an additional scaling metric, based on in-flight queries (like "querier"), for the ruler-querier. I will upstream the additional scaling metric to OSS jsonnet, as soon as we've done rolling out at Grafana Labs. In the meanwhile I would like to add the additional scaling metric to "Remote rule reads" dashboard.

In this PR you can find a couple of commits:

Example of the updated dashboard:

Screenshot 2024-03-29 at 08 54 58

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

…plicasByScalingMetricPanel(), and autoScalingFailuresPanel() jsonnet utility functions

Signed-off-by: Marco Pracucci <marco@pracucci.com>
…ing metric panel

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
$.autoScalingFailuresPanel('ruler_querier')
)
)
.addRowIf(
Copy link
Collaborator Author

@pracucci pracucci Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: I've split it into 2 rows because 5 panels in a row were too crowded even on my pretty large screen. See PR description for a screenshot showing the resulting dashboard.

@pracucci pracucci marked this pull request as ready for review March 29, 2024 08:03
@pracucci pracucci requested a review from a team as a code owner March 29, 2024 08:03
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the split commits make this much easier to review!

@pracucci pracucci merged commit 1f7b840 into main Apr 2, 2024
31 checks passed
@pracucci pracucci deleted the add-new-ruler-querier-scaling-metric branch April 2, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants