Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mimir-prometheus #7813

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Upgrade mimir-prometheus #7813

merged 2 commits into from
Apr 9, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Apr 5, 2024

What this PR does

This PR upgrades mimir-prometheus to include the changes from grafana/mimir-prometheus#611.

The description of that PR includes a summary of the changes, which I won't repeat here.

Note that prometheus/prometheus#13845 is not relevant to Mimir as we always build with -tags stringlabels now.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review April 5, 2024 00:13
@charleskorn charleskorn requested review from grafanabot and a team as code owners April 5, 2024 00:13
@charleskorn charleskorn merged commit 7ae0342 into main Apr 9, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/upgrade-prometheus branch April 9, 2024 05:57
@pstibrany
Copy link
Member

The description of that PR includes a summary of the changes, which I won't repeat here.

Problem with listing all changes in that summary is that it's not clear what's relevant to Mimir.

@charleskorn
Copy link
Contributor Author

The description of that PR includes a summary of the changes, which I won't repeat here.

Problem with listing all changes in that summary is that it's not clear what's relevant to Mimir.

I tried to separate out the changes relevant and not relevant to Mimir in that PR description - is there another way that would make this clearer?

@pstibrany
Copy link
Member

pstibrany commented Apr 10, 2024

Problem with listing all changes in that summary is that it's not clear what's relevant to Mimir.

I tried to separate out the changes relevant and not relevant to Mimir in that PR description - is there another way that would make this clearer?

I clearly didn't read your description with enough attention! 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants