Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded compactor in querier e2e test #7978

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

56quarters
Copy link
Contributor

What this PR does

This compactor was added in #6779 but isn't actually needed since we're testing monolithic mode which already includes the compactor component.

Coincidentally, this also seems to fix #7972

Which issue(s) this PR fixes or relates to

Fixes #7972

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

This compactor was added in #6779 but isn't actually needed since we're
testing monolithic mode which already includes the compactor component.

Coincidentally, this also seems to fix #7972

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters marked this pull request as ready for review April 25, 2024 19:14
@56quarters 56quarters requested a review from a team as a code owner April 25, 2024 19:14
@56quarters 56quarters merged commit b2476b5 into main Apr 25, 2024
29 checks passed
@56quarters 56quarters deleted the 56quarters/query-flake branch April 25, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky TestQuerierWithBlocksStorageRunningInSingleBinaryMode
2 participants