Non-ingesters should not fail on its config validation #7990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamida
approved these changes
Apr 28, 2024
narqo
force-pushed
the
7822-ingester-config-validation
branch
2 times, most recently
from
0b312bf
to
a5f39a6
Compare
dimitarvdimitrov
approved these changes
Apr 30, 2024
pkg/mimir/mimir.go
Outdated
| if c.isAnyModuleEnabled(Ingester, Write, All) || !errors.Is(err, ingester.ErrSpreadMinimizingValidation) { | ||
| return errors.Wrap(err, "invalid ingester config") | ||
| } | ||
| level.Warn(log).Log("ingester config is invalid; moving on because the \"ingester\" module is not in this process's targets", "err", err.Error()) |
There was a problem hiding this comment.
i'd opt for a debug log here. It shouldn't be anything to worry about. WDYT?
Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
narqo
force-pushed
the
7822-ingester-config-validation
branch
from
a5f39a6
to
b9ebb43
Compare
…g validation Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
narqo
force-pushed
the
7822-ingester-config-validation
branch
from
b9ebb43
to
2a36e8e
Compare
dimitarvdimitrov
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
These changes fix an issue with mimir's config validation, where non-ingester modules fail on its config validation, when
-ingester.ring.token-generation-strategy=spread-minimizingis set.Which issue(s) this PR fixes or relates to
Fixes #7822
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.