Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "queue length" panel on Ruler dashboard #8006

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Apr 30, 2024

What this PR does

This PR fixes an issue with the Ruler dashboard, where the "queue length" panel does not show the expected results.

cortex_prometheus_notifications_queue_length and cortex_prometheus_notifications_queue_capacity are both gauges defined here, so taking the rate of them will not produce the desired result.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review April 30, 2024 03:57
@charleskorn charleskorn requested a review from a team as a code owner April 30, 2024 03:57
@charleskorn charleskorn merged commit 37e2aa1 into main Apr 30, 2024
31 checks passed
@charleskorn charleskorn deleted the charleskorn/fix-dashboard branch April 30, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants