Runbook: Add extra runbook information for distroless images #8235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that distroless images are published by default this information will be of interest to operators.
dimitarvdimitrov
approved these changes
May 31, 2024
pstibrany
approved these changes
May 31, 2024
charleskorn
reviewed
Jun 2, 2024
Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
jhesketh
commented
Jun 3, 2024
jhesketh
commented
Jun 3, 2024
jhesketh
commented
Jun 3, 2024
charleskorn
reviewed
Jun 4, 2024
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Grafana Mimir | |||
|
|
|||
| * [FEATURE] Alertmanager: Added `-alertmanager.max-silences-count` and `-alertmanager.max-silence-size-bytes` to set limits on per tenant silences. Disabled by default. #6898 | |||
There was a problem hiding this comment.
Did you mean to add this here?
There was a problem hiding this comment.
I don't see this change as part of this PR 🤔
There was a problem hiding this comment.
It's not. It was just in the wrong place in the changelog and it got confusing. We fixed it in #8266
narqo
pushed a commit
to narqo/grafana-mimir
that referenced
this pull request
Jun 6, 2024
…#8235) * Runbook: Add extra runbook information for distroless images Now that distroless images are published by default this information will be of interest to operators. * Update changelog * Build doc * Apply suggestions from code review Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com> * Apply suggestions from code review * Update docs/sources/mimir/manage/mimir-runbooks/_index.md --------- Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that distroless images are published by default this information will be of interest to operators.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.