Support limits for silences #8241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
approved these changes
May 31, 2024
grobinson-grafana
force-pushed
the
grobinson/support-silence-limits-in-mimir
branch
4 times, most recently
from
7e78842
to
f2ae89c
Compare
grobinson-grafana
force-pushed
the
grobinson/support-silence-limits-in-mimir
branch
from
3126d2d
to
7d7a12c
Compare
56quarters
approved these changes
May 31, 2024
| Metrics: am.registry, | ||
| Limits: silence.Limits{ | ||
| MaxSilences: cfg.Limits.AlertmanagerMaxSilencesCount(cfg.UserID), | ||
| MaxPerSilenceBytes: cfg.Limits.AlertmanagerMaxSilenceSizeBytes(cfg.UserID), |
There was a problem hiding this comment.
max-per-silence-bytes makes this limit a lot easier to understand (compared to max-silence-size-bytes). WDYT about using max per silence bytes everywhere? OK too if you'd like to keep it as-is for consistency with other limits.
EDIT: lol, I see @alexweav suggested the opposite. Ignore me!
There was a problem hiding this comment.
I would like to keep it consistent with other limits 🙂
alexweav
approved these changes
May 31, 2024
duricanikolic
added a commit
that referenced
this pull request
Jun 2, 2024
This reverts commit 2ead4da.
narqo
pushed a commit
to narqo/grafana-mimir
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This pull request adds support for silence limits prometheus/alertmanager#3852.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.