Prevent ingesting samples older than past_grace_period
#8262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements a new limit, similar to `creation_grace_period`, that limits the age of the ingested samples based on the wall clock. It also takes into account the OOO window, to avoid having to change both settings when OOO window is modified. The default value of 1 week should cover any observability needs. If some customer wants to backfill their samples in order, they can increase the value of that to `100y` in the config to cover 100 years, for example. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
|
I'll wait for @jdbaldry's review on the runbooks before merging. |
jdbaldry
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Docs LGTM and are consistent with the rest of the runbook format.
nit: consider using contractions to match our tone guidelines: https://grafana.com/docs/writers-toolkit/write/style-guide/voice-tone-guidelines/#tone
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
colega
commented
Jun 6, 2024
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR implements a new limit, similar to
creation_grace_period, that limits the age of the ingested samples based on the wall clock.It also takes into account the OOO window, to avoid having to change both settings when OOO window is modified.
The default value of 1 week should cover any observability needs. If some customer wants to backfill their samples in order, they can increase the value of that to
100yin the config to cover 100 years, for example.Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.