usage reporting: report utilized CPU time #8282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does usage reporting need to include CPU usage? This seems like operation data that isn't appropriate to include in usage stats and something better done with metrics. |
|
this is for GEM billing purposes. That's what Loki (and GEL) did, so we followed suit. I think it's equally viable to do this in GEM only. |
|
The usage report already contains:
This is an improvement to the second item, bringing it more inline with the first (usage rather than raw available core count). |
pr00se
reviewed
Jun 6, 2024
dimitarvdimitrov
force-pushed
the
dimitar/usage-stats/add-cpu-percentage-reporting
branch
from
47e224a
to
b4128fe
Compare
dimitarvdimitrov
requested review from
stevesg,
grafanabot,
a team and
jdbaldry
as code owners
dimitarvdimitrov
commented
Jun 7, 2024
This takes a similar approach to Loki Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
force-pushed
the
dimitar/usage-stats/add-cpu-percentage-reporting
branch
from
e8a873c
to
b23008a
Compare
dimitarvdimitrov
deleted the
dimitar/usage-stats/add-cpu-percentage-reporting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This takes a similar approach to Loki's grafana/loki#12970 and replaces number of CPU cores to the actual CPU utilization
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.