Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimir query engine: extend binary operation tests to assert on error messages #8340

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Jun 11, 2024

What this PR does

This PR makes use of prometheus/prometheus#14038 to assert that the error messages returned by binary operations are as expected when multiple matching series are found on one side of a one-to-one match.

Note that Prometheus' engine and Mimir's engine return different but equivalent error messages: Mimir's engine includes more detail in all cases.

Which issue(s) this PR fixes or relates to

Addresses TODO from #8096

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review June 11, 2024 11:35
@charleskorn charleskorn requested a review from a team as a code owner June 11, 2024 11:35
@charleskorn charleskorn merged commit 05cf5c7 into main Jun 12, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/binary-operators-error-assertions branch June 12, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants