[r294] Ingester: split push and read circuit breakers #8358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ingester: splitting push and read circuit breakers Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Improving TestIngester_StartReadRequest Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Updating documentation Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing lint issues Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing documentation issues Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Do not call tryAcquirePermit() on the push cb from tryReadAcquirePermit() Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Rename prCircuitBreaker into ingesterCircuitBreaker Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Rename label name path to request_type and label value write to push Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Do not allow acquiring permit if cbs are not active Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> --------- Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> (cherry picked from commit ee069d2)
56quarters
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ee069d2 from #8315