frontend: clone headers in WithXXX query request methods
#8379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
|
Why do we need to clone them? Can we have a test explaining it? Otherwise, there's nothing preventing me from sending a follow up PR cleaning up that function call, which "isn't needed". |
ref: #8379 (comment) Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
ortuman
force-pushed
the
ortuman/frontend/clone-headers-in-prometheus-query-request
branch
from
69d26a4
to
7048187
Compare
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
ortuman
force-pushed
the
ortuman/frontend/clone-headers-in-prometheus-query-request
branch
from
c6bedda
to
7a2908b
Compare
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
colega
approved these changes
Jun 17, 2024
ortuman
deleted the
ortuman/frontend/clone-headers-in-prometheus-query-request
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
follow-up of #8342
This PR extends the cloning of headers in all
WithXXXmethods for instant and range query requests.Which issue(s) this PR fixes or relates to
Fixes N/A