Add return error support to MetricsQueryRequest.WithStartEnd()

[pracucci]

What this PR does

In #8374 I've an use case where WithStartEnd() may return error. In this PR I propose to add error return support to WithStartEnd(). We already use the same pattern in WithQuery(), reason why I don't think this change is much contentious.

Which issue(s) this PR fixes or relates to

N/A

Checklist

• Tests updated.
• Documentation added.
• CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
• about-versioning.md updated with experimental features.

[krajorama]

nit: To me panic in test implies that it's catching a programming error that should never happen in real life. I'd use require.NoError() or assert.NoError and pass t.

[pracucci]

I agree with you. It's a bit annoying having to pass t because can't be a wrapper anymore. The closest thing would be:

func mustNoError[T any](t *testing.T) func(value T, err error) T {
       return func(value T, err error) T {
               require.NoError(t, err)
               return value
       }
}

And then you can call it like this:

-                       requestB:      mustSucceed(rangeQuery.WithStartEnd(rangeQuery.GetStart()+5*time.Minute.Milliseconds(), rangeQuery.GetEnd()+5*time.Minute.Milliseconds())),
+                       requestB:      mustNoError[MetricsQueryRequest](t)(rangeQuery.WithStartEnd(rangeQuery.GetStart()+5*time.Minute.Milliseconds(), rangeQuery.GetEnd()+5*time.Minute.Milliseconds())),

I think this latter version makes code a bit more ugly. Given the panic affects only tests I will move on.

[krajorama]

approved with nit