Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval: Allow map key as expression #896

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

julienduchesne
Copy link
Member

If the first level trying to eval has characters like - or . in them, it's currently impossible to eval
With this PR, we can do -e '["my-key"]'

If the first level trying to eval has characters like `-` or `.` in them, it's currently impossible to eval
With this PR, we can do `-e '["my-key"]'`
@julienduchesne julienduchesne requested a review from a team August 3, 2023 16:11
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-08-04 13:59 UTC

Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, I've wanted this before 👍

would it be possible to add a test?

@julienduchesne
Copy link
Member Author

would it be possible to add a test?

Done!

@julienduchesne julienduchesne merged commit 8e496b7 into main Aug 4, 2023
1 check passed
@julienduchesne julienduchesne deleted the julienduchesne/allow-evaluating-maps branch August 4, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants