Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple traffic redirector creation from protocol disruptor #212

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

pablochacin
Copy link
Collaborator

Description

Decouple the creation of the traffic redirector from the protocol disruptor, facilitating using different implementations, like for example a noop traffic redirector used for non-transparent proxy (see #169)

Checklist:

  • My code follows the coding style of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin requested a review from roobre June 16, 2023 14:43
Copy link
Collaborator

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left just a simple comment about a (seemingly) unused var.

cmd/agent/commands/grpc.go Outdated Show resolved Hide resolved
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin merged commit 716a0a5 into main Jun 19, 2023
6 checks passed
@pablochacin pablochacin deleted the refactor-traffic-redirector branch June 19, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants