Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package version #269

Merged
merged 6 commits into from
Aug 3, 2023
Merged

Fix package version #269

merged 6 commits into from
Aug 3, 2023

Conversation

pablochacin
Copy link
Collaborator

Description

Separates the disruptor version to build from the release version to better handle different use cases such as publishing the latest development version or publishing a release.

Fixes #268

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have run relevant e2e test locally (make e2e-xxx for agent, disruptors, kubernetes or cluster related changes)
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin force-pushed the fix-package-version branch 2 times, most recently from 5e04601 to 8e8875f Compare August 1, 2023 12:34
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin marked this pull request as ready for review August 3, 2023 08:17
@pablochacin pablochacin requested a review from roobre August 3, 2023 08:17
Copy link
Collaborator

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, the split into three makes the thing very easy to read.

Left a few nits suggesting moving away from double negations (! -z).

.github/workflows/publish.yml Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
Co-authored-by: Roberto Santalla <roobre@users.noreply.github.com>
@pablochacin pablochacin merged commit 110e05b into main Aug 3, 2023
6 checks passed
@pablochacin pablochacin deleted the fix-package-version branch August 3, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build for non-release versions is fails
2 participants