Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grails5 update #109

Merged
merged 23 commits into from
Nov 28, 2023
Merged

Grails5 update #109

merged 23 commits into from
Nov 28, 2023

Conversation

Richardson-e
Copy link
Contributor

@Richardson-e Richardson-e commented Oct 4, 2023

Update module to groovy 3, grails 5, compliance with stricter compiler

Copy link
Contributor

@puneetbehl puneetbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Gradle, api and implementation are two different configurations that you can use to declare dependencies in your build.gradle file for a Java or Grails project. They serve different purposes and have different visibility scopes, and understanding when to use each one is important for managing your project's dependencies effectively.

  1. api:
    • Use for dependencies that are part of your module's public API.
    • Accessible to other modules that depend on your module.
dependencies {
    api 'com.example:public-library:1.0'
}
  1. implementation:
    • Use for internal dependencies not exposed to other modules.
    • Not visible to modules that depend on your module.
dependencies {
    implementation 'com.example:internal-library:1.0'
}
  1. Example with both api and implementation:
dependencies {
    api 'com.example:public-library:1.0' // Public API dependency
    implementation 'com.example:internal-library:1.0' // Internal dependency
}

Using these configurations helps manage dependencies' visibility and reduces potential conflicts.

I would suggest to check out The Java Library Plugin documentation.

@guillermocalvo guillermocalvo force-pushed the grails5-update branch 2 times, most recently from 758e5af to 671e544 Compare October 23, 2023 11:39
@puneetbehl
Copy link
Contributor

@guillermocalvo Please resolve the conflicts

@puneetbehl
Copy link
Contributor

@guillermocalvo Could you please take a look into this?

@guillermocalvo guillermocalvo dismissed puneetbehl’s stale review November 27, 2023 10:39

Dependency scopes are fixed now

@puneetbehl puneetbehl merged commit 8409fa9 into 3.0.x Nov 28, 2023
2 checks passed
@puneetbehl puneetbehl deleted the grails5-update branch November 28, 2023 18:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants