Fix loadDerived not taking entity cache into consideration when loading derived entities
#4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…derived_entities
lutter
requested changes
Aug 9, 2023
incrypto32
force-pushed
the
incrypto32/fix-same-transaction-dervide-loaders-issue
branch
2 times, most recently
from
b9cd862
to
259cda0
Compare
incrypto32
force-pushed
the
incrypto32/fix-same-transaction-dervide-loaders-issue
branch
2 times, most recently
from
2325994
to
0371ee2
Compare
incrypto32
force-pushed
the
incrypto32/fix-same-transaction-dervide-loaders-issue
branch
from
0371ee2
to
9c41c38
Compare
lutter
requested changes
Aug 10, 2023
incrypto32
force-pushed
the
incrypto32/fix-same-transaction-dervide-loaders-issue
branch
from
817d61f
to
f70ee0e
Compare
incrypto32
force-pushed
the
incrypto32/fix-same-transaction-dervide-loaders-issue
branch
from
f70ee0e
to
626890b
Compare
incrypto32
force-pushed
the
incrypto32/fix-same-transaction-dervide-loaders-issue
branch
from
f248968
to
c7bce0d
Compare
incrypto32
commented
Aug 11, 2023
lutter
approved these changes
Aug 11, 2023
|
|
||
| for (key, entity) in entity_map.iter() { | ||
| // Only insert to the cache if it's not already there | ||
| // This is to avoid overwriting updates |
There was a problem hiding this comment.
Since self.current only contains entities that have already been written to the store, there's no danger of clobbering an update. It's still good to add those entities to self.current, it's just that the comment is misleading.
There was a problem hiding this comment.
in that case should we just insert it without checking ? Is there a reason to keep the check?
|
@lutter Any idea why the runner tests are failing with |
|
The runners test issue was a yarn workspace issue. fixed it |
incrypto32
deleted the
incrypto32/fix-same-transaction-dervide-loaders-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4727