Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RAV value threshold per sender #93

Closed
aasseman opened this issue Nov 13, 2023 · 0 comments · Fixed by #113
Closed

Make RAV value threshold per sender #93

aasseman opened this issue Nov 13, 2023 · 0 comments · Fixed by #113
Assignees
@aasseman
Labels
p1 High priority size:medium Medium type:feature New or enhanced functionality
Milestone
TAP Agent ready f...

Comments

@aasseman
Copy link
Collaborator 

          That's a good point. Is our thinking so far that the RAV request threshold is per `(sender, allocation)`? From a user (i.e. indexer) perspective, that doesn't feel very intuitive. More intuitive would indeed be: "per sender, I'm willing to run a risk of X GRT remaining uncollectable". That would also open the door to per-sender risk thresholds.

Originally posted by @Jannis in #83 (comment)
@aasseman aasseman self-assigned this Nov 13, 2023
@aasseman aasseman added size:medium Medium p1 High priority type:feature New or enhanced functionality labels Nov 13, 2023
@aasseman aasseman added this to the TAP Agent ready for prod milestone Nov 13, 2023
@aasseman aasseman mentioned this issue Nov 13, 2023
Merged
@aasseman aasseman removed their assignment Nov 14, 2023
@aasseman aasseman assigned aasseman and unassigned aasseman Nov 23, 2023
@aasseman aasseman self-assigned this Jan 23, 2024
aasseman added a commit that referenced this issue Jan 31, 2024
@aasseman
Make RAV value threshold per sender
ca55cea 
Fixes #93

Signed-off-by: Alexis Asseman <[email protected]>
aasseman added a commit that referenced this issue Jan 31, 2024
@aasseman
Make RAV value threshold per sender
4dd0687 
Fixes #93

Signed-off-by: Alexis Asseman <[email protected]>
@aasseman aasseman mentioned this issue Jan 31, 2024
Merged
aasseman added a commit that referenced this issue Feb 16, 2024
@aasseman
Make RAV value threshold per sender
57afc67 
Fixes #93

Signed-off-by: Alexis Asseman <[email protected]>
aasseman added a commit that referenced this issue Feb 16, 2024
@aasseman @gusinacio
Make RAV value threshold per sender (#113)
308562e 
* Make RAV value threshold per sender
Fixes #93

Signed-off-by: Alexis Asseman <[email protected]>

* fix: simplify rav_requester_finalize error handling

Signed-off-by: Alexis Asseman <[email protected]>

* fix: proper signer/sender handling at startup DB SenderAccount loading

Signed-off-by: Alexis Asseman <[email protected]>

* test: cleanup

Signed-off-by: Alexis Asseman <[email protected]>

* fix: nested SQL query in sender_accounts_manager

Signed-off-by: Alexis Asseman <[email protected]>

* refactor: move static methods into Inner impl

Signed-off-by: Alexis Asseman <[email protected]>

* refactor: simplify SenderAcccount's fees_add

Signed-off-by: Alexis Asseman <[email protected]>

* refactor: replace active and ineligible allocations with AllocationStateEnum and single HashMap

Signed-off-by: Alexis Asseman <[email protected]>

* fix: locking issue and recompute unaggregated fees

* fix: unaggregated fees update race condition with tokio mutex guards

Signed-off-by: Alexis Asseman <[email protected]>

* chore: fix comments

Signed-off-by: Alexis Asseman <[email protected]>

* fix: use std mutex for sender_accounts

Signed-off-by: Alexis Asseman <[email protected]>

---------

Signed-off-by: Alexis Asseman <[email protected]>
Co-authored-by: Gustavo Inacio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aasseman aasseman

Labels
p1 High priority size:medium Medium type:feature New or enhanced functionality
Projects
None yet
Milestone
TAP Agent ready for prod
Development

Successfully merging a pull request may close this issue.

Make RAV value threshold per sender graphprotocol/indexer-rs
1 participant
@aasseman