Preserve defaultValue literals #3810
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
default-value-literals-rebased
branch
from
f7d4e56
to
4883f29
Compare
yaacovCR
force-pushed
the
default-value-literals-rebased
branch
from
4883f29
to
023cd9c
Compare
yaacovCR
force-pushed
the
default-value-literals-rebased
branch
5 times, most recently
from
cafef7b
to
7a927c5
Compare
yaacovCR
force-pushed
the
default-value-literals-rebased
branch
2 times, most recently
from
c3fc46d
to
0376313
Compare
yaacovCR
force-pushed
the
default-value-literals-rebased
branch
from
0376313
to
619c450
Compare
yaacovCR
force-pushed
the
default-value-literals-rebased
branch
from
619c450
to
fd87704
Compare
yaacovCR
force-pushed
the
default-value-literals-rebased
branch
8 times, most recently
from
7c8cc2c
to
47081cb
Compare
yaacovCR
force-pushed
the
default-value-literals-rebased
branch
from
47081cb
to
f6feca9
Compare
yaacovCR
force-pushed
the
default-value-literals-rebased
branch
4 times, most recently
from
0439857
to
52aa101
Compare
Fixes graphql#3051 This change solves the problem of default values defined via SDL not always resolving correctly through introspection by preserving the original GraphQL literal in the schema definition. This changes argument and input field definitions `defaultValue` field from just the "value" to a new `GraphQLDefaultValueUsage` type which contains either -- but not both -- "value" and "literal" fields. Here is the flow for how a default value defined in an SDL would be converted into a functional schema and back to an SDL: **Before this change:** ``` (SDL) --parse-> (AST) --coerceInputLiteral--> (defaultValue config) --valueToAST--> (AST) --print --> (SDL) ``` `coerceInputLiteral` performs coercion which is a one-way function, and `valueToAST` is unsafe and set to be deprecated in graphql#3049. **After this change:** ``` (SDL) --parse-> (defaultValue literal config) --print --> (SDL) ```
yaacovCR
force-pushed
the
default-value-literals-rebased
branch
from
52aa101
to
fdce4b2
Compare
JoviDeCroock
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3074 rebased on main.
Depends on #3809
@leebyron comments from original PR (edited, hopefully correctly):