Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit definition for BlockString #1042

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Aug 29, 2023

As pointed out by @sungam3r in #899, we state:

In the type system definition language, these description strings (often {BlockString}) occur immediately before the definition they describe.

However, we don't have a definition for BlockString.

I've elevated BlockString to be its own entity, and StringValue now uses that definition instead.

GraphQL.js already has a BlockString token type: https://github.com/graphql/graphql-js/blob/b12dcffe83098922dcc6c0ec94eb6fc032bd9772/src/language/tokenKind.ts#L27 so I think this is just an edit to reflect reality and doesn't really require the RFC process.

@graphql/tsc Can I get some +1s? I'll also add it to the Sept 7 WG in case anyone feels we shouldn't do this.

@benjie benjie added the ✏️ Editorial PR is non-normative or does not influence implementation label Aug 29, 2023
@benjie benjie requested a review from a team August 29, 2023 15:58
@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 17c75f8
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/64ee15a0dd280000089d5697
😎 Deploy Preview https://deploy-preview-1042--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@fotoetienne fotoetienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@benjie
Copy link
Member Author

benjie commented Sep 8, 2023

With all these approvals I'm going to go ahead and merge this; we can always undo it if we need to 👍

Thanks everyone!

@benjie benjie merged commit 3adfcca into graphql:main Sep 8, 2023
10 checks passed
@benjie benjie deleted the blockstring branch September 8, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editorial PR is non-normative or does not influence implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants