Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative spec implementation of deduplicated incremental delivery #1077

Closed
wants to merge 39 commits into from
Closed

Alternative spec implementation of deduplicated incremental delivery #1077

wants to merge 39 commits into from

Commits on Sep 18, 2024

  1. Extract common logic from ExecuteQuery, ExecuteMutation and ExecuteSu… 

    …bscriptionEvent
    @benjie @yaacovCR
    benjie authored and yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1b4e808 View commit details
    Browse the repository at this point in the history

  2. Change ExecuteSelectionSet to ExecuteGroupedFieldSet

    @benjie @yaacovCR
    benjie authored and yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c4eda2d View commit details
    Browse the repository at this point in the history

  3. Correct reference to MergeSelectionSets

    @benjie @yaacovCR
    benjie authored and yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    018dac8 View commit details
    Browse the repository at this point in the history

  4. moves Field Collection section earlier

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a620dc1 View commit details
    Browse the repository at this point in the history

  5. Introduce @defer directive

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4e6df5c View commit details
    Browse the repository at this point in the history

  6. refactor a few lines out of YieldSubsequentResults

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e09dcf2 View commit details
    Browse the repository at this point in the history

  7. add a word or two about which child nodes are being promoted

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d4934b3 View commit details
    Browse the repository at this point in the history

  8. be more graphy

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fd3987c View commit details
    Browse the repository at this point in the history

  9. fix timing

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a94d7c0 View commit details
    Browse the repository at this point in the history

  10. reuse function

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    acc720b View commit details
    Browse the repository at this point in the history

  11. fix

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6d3fccb View commit details
    Browse the repository at this point in the history

  12. rename BuildGraph to GraphFromRecords

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9237ed2 View commit details
    Browse the repository at this point in the history

  13. reword recursive abort case

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    76b7385 View commit details
    Browse the repository at this point in the history

  14. bring BuildFieldPlan in line with implementation

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f3b6a3f View commit details
    Browse the repository at this point in the history

  15. rename "deferred grouped field set record" to "execution group"

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3194566 View commit details
    Browse the repository at this point in the history

  16. rename ExecuteExecutionGroup to CollectExecutionGroup

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ab8ccc3 View commit details
    Browse the repository at this point in the history

  17. properly initialize deferUsages with their parents

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    14b107f View commit details
    Browse the repository at this point in the history

  18. move Field Collection back to where it was 

    mostly to reduce the diff.
    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1645856 View commit details
    Browse the repository at this point in the history

  19. f

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    76c2a98 View commit details
    Browse the repository at this point in the history

  20. use fieldDetailsList consistently 

    instead of sometimes fieldGroup, for consistency and so as to remove another "Group" term
    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    81a9353 View commit details
    Browse the repository at this point in the history

  21. add info re: data structures

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    74bfb43 View commit details
    Browse the repository at this point in the history

  22. rename FieldPlan to ExecutionPlan

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    215d4f3 View commit details
    Browse the repository at this point in the history

  23. path => label

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    375804c View commit details
    Browse the repository at this point in the history

  24. add missing arguments

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9ad6065 View commit details
    Browse the repository at this point in the history

  25. add missing return value

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    895428c View commit details
    Browse the repository at this point in the history

  26. fix some renaming around CollectExecutionGroups and ExecuteExecutionG… 

    …roup
    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    255ef41 View commit details
    Browse the repository at this point in the history

  27. Correct argument name 

    "node" should be "field" within CreateSourceEventStream

Co-authored-by: Rob Richard <robrichard87@gmail.com>
    @yaacovCR @robrichard
    yaacovCR and robrichard committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4bd72b4 View commit details
    Browse the repository at this point in the history

  28. clarify errors from ExecuteExecutionPlan 

    accompanying note is a WIP, open to further suggestions as to how to clarify
    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7c0088e View commit details
    Browse the repository at this point in the history

  29. add initial versions of explanations for the algorithms in the "Execu… 

    …ting an Execution Plan" section
    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6cc43d1 View commit details
    Browse the repository at this point in the history

  30. add subheadings

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e1e50c9 View commit details
    Browse the repository at this point in the history

  31. adjust heading

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6c9d9ee View commit details
    Browse the repository at this point in the history

  32. Initialize graph

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    29598b1 View commit details
    Browse the repository at this point in the history

  33. adjust YieldSubsequentResults algorithm per review

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4bb4fde View commit details
    Browse the repository at this point in the history

  34. reuse GetIncrementalResult() for the error case

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f2aec2a View commit details
    Browse the repository at this point in the history

  35. add descriptions and fix bug within GetNewRootNodes, it needs the old… 

    … root nodes before the graph was adjusted
    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6862323 View commit details
    Browse the repository at this point in the history

  36. finish addressing review comments

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8dad2e8 View commit details
    Browse the repository at this point in the history

  37. add missing word

    @yaacovCR
    yaacovCR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fb94bc6 View commit details
    Browse the repository at this point in the history

  38. Add Response Section for defer/stream (#4) 

    * Add Response Section for defer/stream

* review fixes

* fix
    @robrichard
    robrichard committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    99107f0 View commit details
    Browse the repository at this point in the history

  39. Add directives and validation sections (#5) 

    * Add defer and stream directives to type system

* Add defer/stream validation rules
    @robrichard
    robrichard committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3ef628c View commit details
    Browse the repository at this point in the history