Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix punctuation in grammar rule #1084

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Mar 11, 2024

Thanks to @BoD for spotting a missed . in section 2.

This also includes a loosey-goosey detection for algorithms related to grammars in section 2, which catches this issue but doesn't find any others.

Fixes #994

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 5fda732
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/666300c258aff0000897a0e8
😎 Deploy Preview https://deploy-preview-1084--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benjie
Copy link
Member Author

benjie commented Mar 11, 2024

cc @Keweiqu / @mjmahone

@benjie

This comment was marked as resolved.

@benjie
Copy link
Member Author

benjie commented Jun 7, 2024

This is just indentation now since #994 was merged. The lint script can be reverted easy enough so I'm going to go ahead and merge to help avoid more formatting issues being introduced into the spec.

@benjie benjie merged commit e5bddd9 into graphql:main Jun 7, 2024
9 checks passed
@benjie benjie deleted the fix-punctuation-checks branch June 7, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants