Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always read tsh profile. #1049

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Always read tsh profile. #1049

merged 1 commit into from
Jun 7, 2017

Conversation

russjones
Copy link
Contributor

Purpose

At the moment, we are only reading tsh profiles if you do not set the --proxy flag. This PR changes this behavior to always read profiles.

Implementation

tsh behavior has been changed to always read profiles.

  • If no --proxy flag is set, then it reads from the default profile symlink ~/<tsh-dir>/profile.
  • If the --proxy flag is set, then read profile from ~/<tsh-dir>/<proxy-host>.yaml.

Related Issues

Fixes #1047

@russjones russjones requested a review from kontsevoy June 7, 2017 18:33
Copy link
Contributor

@kontsevoy kontsevoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned that "username" profile setting was ignored, forcing people with valid profiles to keep adding --user=john@example.com to their tsh ssh command. I do not see any changes to address that.

@russjones
Copy link
Contributor Author

@kontsevoy This fixes the --user=john@example.com issue. That issue was occurring when you were trying to do tsh --proxy=localhost ssh localhost and we would not load your profile because you specified a proxy.

@kontsevoy
Copy link
Contributor

lgtm then

@russjones russjones merged commit b30dacf into master Jun 7, 2017
@russjones russjones deleted the rjones/fix-profile branch June 7, 2017 18:42
hatched pushed a commit that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants