Set some defaults from identity file. #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizhentas
force-pushed
the
sasha/identity
branch
4 times, most recently
from
255c25e
to
2daefc0
Compare
r0mant
approved these changes
Sep 13, 2018
| if err != nil { | ||
| return trace.Wrap(err) | ||
| } | ||
| if _, err = output.Write([]byte(data)); err != nil { |
There was a problem hiding this comment.
Should this be prefixed by \n in case the previous write didn't add a new line?
kontsevoy
approved these changes
Sep 13, 2018
This commit reduces the amount of typing some users have to do when using identity file: * Teleport user is set from the certificate * Auth preference is set to local In addition it fixes several UX problems: * Commands `tctl auth sign` and `tsh login -o` now include trusted CA keys in the identity file. * Command `tsh ssh -i` is now noninteractive and only uses identity file for authentication, in case if identity file can not authenticate, no other interactive or non-interactive authentication methods will be used. Before this commit, tsh tried to fallback to interactive login mode or read the keys from agent socket.
klizhentas
force-pushed
the
sasha/identity
branch
from
2daefc0
to
a8a2e05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of typing some users have
to do when using identity file: