Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor redirect flow and fix URLs for --bind-addr #2650

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

klizhentas
Copy link
Contributor

No description provided.

@osterman
Copy link

Thanks @klizhentas !

s.string = v
}

// ClickableURL fixes address in url to m
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfinished comment.

@russjones
Copy link
Contributor

Code looks fine, but it's large enough where it can be encapsulated within it's own struct with methods that you can call from SSHAgentSSOLogin.

Something like:

type callbackServer struct{
}

func (s *callbackServer) handleCallback(w http.ResponseWriter, r *http.Request) {
   [...]
}

func (s *callbackServer) handleRedir(w http.ResponseWriter, r *http.Request) {
   [...]
}

func (s *callbackServer) Start() {
   [...]
}

func (s *callbackServer) Close() error {
   [...]
}

@klizhentas klizhentas merged commit 34ef37a into branch/3.2 Apr 15, 2019
@klizhentas klizhentas deleted the sasha/bind-addr-2 branch April 15, 2019 20:41
@klizhentas
Copy link
Contributor Author

@russjones I'll look into refactor a bit later, may be do some work in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants