Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix web sessions ID compatibility #2993

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Conversation

fspmarshall
Copy link
Contributor

Use legacy IDs when generating session IDs for web client. The version-request mechanism used elsewhere doesn't cover this case since frontend requests a session ID before dialing node.

lib/web/apiserver.go Outdated Show resolved Hide resolved
@fspmarshall fspmarshall force-pushed the fspmarshall/fix-web-sessions branch 2 times, most recently from 6126e12 to de91d8e Compare September 16, 2019 21:03
Copy link
Contributor

@klizhentas klizhentas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to squash the commits :)_

@fspmarshall
Copy link
Contributor Author

@gravitational-jenkins retest this please.

@fspmarshall fspmarshall merged commit 94808fd into master Sep 17, 2019
@fspmarshall fspmarshall deleted the fspmarshall/fix-web-sessions branch September 17, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants