Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.2 Documentation Base #3154

Merged
merged 16 commits into from
Dec 18, 2019
Merged

4.2 Documentation Base #3154

merged 16 commits into from
Dec 18, 2019

Conversation

benarent
Copy link
Contributor

@benarent benarent commented Nov 13, 2019 •
edited
Loading

Base for Docs content - #3133

@benarent benarent changed the title WIP - 4.2 Documentation Base 4.2 Documentation Base Dec 11, 2019
@benarent
4.2 - Docs: Workflow Beta (#3155)
7dbd755 
* Overview of Approval Workflows.
@benarent benarent added this to the 4.2 "Alameda" milestone Dec 17, 2019
webvictim
webvictim reviewed Dec 18, 2019
View reviewed changes
docs/4.2/gcp_guide.md Outdated Show resolved Hide resolved
webvictim
webvictim approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@webvictim webvictim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I obviously haven't read all 13,400 lines but I think pretty much all of this has been reviewed elsewhere.

@benarent benarent merged commit 46eefa1 into master Dec 18, 2019
@benarent benarent deleted the benarent/docs/4.2-base branch December 18, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webvictim webvictim webvictim approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
4.2 "Alameda"
Development

Successfully merging this pull request may close these issues.
2 participants
@benarent @webvictim