Set SameSite attribute on CSRF cookie #3441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-kovoy
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
alex-kovoy
force-pushed
the
alexey/samesiteattr
branch
from
8a016bf
to
1bc3dcd
Compare
kimlisa
approved these changes
Mar 13, 2020
|
@gravitational-jenkins retest this please |
|
retest this please |
1 similar comment
|
retest this please |
|
dear @gravitational-jenkins retest this please one more time :) |
|
@gravitational-jenkins retest this please |
2 similar comments
|
@gravitational-jenkins retest this please |
|
@gravitational-jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3440 by setting SameSite attribute to None on CSRF cookie.