Get teleport /readyz state from heartbeats instead of cert rotation #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
|
LGTM - will leave it for more experienced Go reviewers. |
Heartbeats are more frequent and result in more up-to-date /readyz status. Concretely, it goes from ~10min status update to <1m. Also, refactored the state tracking code to track the status of individual teleport components (auth/proxy/node).
awly
force-pushed
the
andrew/readyz-via-heartbeats
branch
from
fc531e7
to
f58d262
Compare
|
retest this please |
fspmarshall
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heartbeats are more frequent and result in more up-to-date /readyz
status. Concretely, it goes from ~10min status update to <1m.
Also, refactored the state tracking code to track the status of
individual teleport components (auth/proxy/node).
This PR also vendors github.com/stretchr/testify for https://github.com/gravitational/teleport/blob/master/rfd/0001-testing-guidelines.md
Updates #3743