Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Implement basic sidenav #46334

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Web] Implement basic sidenav #46334

wants to merge 4 commits into from

Conversation

rudream
Copy link
Contributor

@rudream rudream commented Sep 6, 2024 •
edited
Loading

Purpose

Part of https://github.com/gravitational/teleport.e/issues/3998

e counterpart: https://github.com/gravitational/teleport.e/pull/4997

This PR adds the first version of the side navigation with basic functionality.

Figma designs

To enable the sidenav view, run this command in the console:

localStorage.setItem("grv_teleport_use_sidenav", "true")

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@rudream rudream changed the title [Web] Implement sidenav v1 [Web] Implement basic sidenav Sep 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

ravicious
ravicious reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll continue the review tomorrow!

web/packages/design/src/theme/themes/sharedStyles.ts Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Main/Main.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
@ravicious ravicious requested review from ravicious and removed request for ravicious September 6, 2024 14:05
kiosion
kiosion reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@kiosion kiosion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from a few a11y-related comments, looks good to me so far, will finish reviewing tomorrow

web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/Navigation.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@rudream rudream added no-changelog Indicates that a PR does not require a changelog entry labels Sep 13, 2024
ravicious
ravicious reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll continue the review on Monday.

web/packages/teleport/src/Navigation/SideNavigation/Navigation.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/Navigation/SideNavigation/Navigation.tsx Show resolved Hide resolved
@ravicious ravicious self-requested a review September 13, 2024 15:39
@rudream rudream mentioned this pull request Sep 20, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiosion kiosion Awaiting requested review from kiosion

@ravicious ravicious Awaiting requested review from ravicious

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rudream @ravicious @kiosion