Add tctl resource commands for AutoUpdateConfig and AutoUpdateVersion #46771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vapopov
added
the
no-changelog
…-resource-command
rosstimothy
reviewed
Sep 19, 2024
tool/tctl/common/resource_command.go
Outdated
Comment on lines
3072
to
3073
| serviceClient := autoupdatev1pb.NewAutoUpdateServiceClient(client.GetConnection()) | ||
| config, err := serviceClient.GetAutoUpdateConfig(ctx, &autoupdatev1pb.GetAutoUpdateConfigRequest{}) |
There was a problem hiding this comment.
Suggested change
| serviceClient := autoupdatev1pb.NewAutoUpdateServiceClient(client.GetConnection()) | |
| config, err := serviceClient.GetAutoUpdateConfig(ctx, &autoupdatev1pb.GetAutoUpdateConfigRequest{}) | |
| config, err := client.GetAutoUpdateConfig(ctx) |
tool/tctl/common/resource_command.go
Outdated
Comment on lines
3079
to
3080
| serviceClient := autoupdatev1pb.NewAutoUpdateServiceClient(client.GetConnection()) | ||
| version, err := serviceClient.GetAutoUpdateVersion(ctx, &autoupdatev1pb.GetAutoUpdateVersionRequest{}) |
There was a problem hiding this comment.
Suggested change
| serviceClient := autoupdatev1pb.NewAutoUpdateServiceClient(client.GetConnection()) | |
| version, err := serviceClient.GetAutoUpdateVersion(ctx, &autoupdatev1pb.GetAutoUpdateVersionRequest{}) | |
| version, err := client.GetAutoUpdateVersion(ctx) |
tool/tctl/common/resource_command.go
Outdated
| return trace.Wrap(err) | ||
| } | ||
|
|
||
| serviceClient := autoupdatev1pb.NewAutoUpdateServiceClient(client.GetConnection()) |
There was a problem hiding this comment.
Should the api.Client implement Create/Update/Upsert like it does Get so that users don't need to construct the additional client manually?
There was a problem hiding this comment.
Not sure if this is necessary, since from proxy side we going to read-only these resources
There was a problem hiding this comment.
The RPCs are exposed via Auth though and any user that has permissions to create/update/get the resource kinds will be able to interact with them via the API client.
rosstimothy
approved these changes
Sep 19, 2024
sclevine
approved these changes
Sep 20, 2024
public-teleport-github-review-bot
bot
removed request for
zmb3 and
hugoShaka
vapopov
added a commit
that referenced
this pull request
Sep 21, 2024
…#46771) * Add autoupdate command for resource * Reuse client methods * Implement all exposed auto update methods for service client * Fix linter
vapopov
added a commit
that referenced
this pull request
Sep 21, 2024
…#46771) * Add autoupdate command for resource * Reuse client methods * Implement all exposed auto update methods for service client * Fix linter
vapopov
added a commit
that referenced
this pull request
Sep 21, 2024
…#46771) * Add autoupdate command for resource * Reuse client methods * Implement all exposed auto update methods for service client * Fix linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR added tctl resource commands for receiving, editing, updating and deleting auto update resources (config and version)